fix: two findings from the agent-skill audit - #69
Open
ziyiunity wants to merge 1 commit into
Open
Conversation
localization: the shipped batch processor contradicted its own guidance. SKILL.md prescribes matching the longest key first so a short string like "NO" cannot match inside a longer sentence, and the processor iterated the mapping Dictionary in enumeration order with a bare Contains. Because the loop breaks on the first hit and marks the label matched, a label reading "NO ITEMS FOUND" bound to a "NO" key and never appeared in the unmatched report -- a silent mis-binding, and an irreproducible one, since Dictionary enumeration order is unspecified. Keys are now sorted longest-first, once. physics-3d-collision: the only reference file restated the spine. All 23 rows of its troubleshooting table are already covered by SKILL.md's eleven Fast-Path sections and twelve checklist steps, in different words. The table is removed and the seven Unity Manual links, which appear nowhere else, are kept. Both reported by Zack Asofsky via the agent-skill-auditor.
UnityZappy
approved these changes
Sep 10, 2026
UnityZappy
left a comment
There was a problem hiding this comment.
LGTM, thank you for updating these skills!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two findings from Zack Asofsky's agent-skill-auditor, both verified before fixing.
1.
localizationships code that contradicts its own guidanceSKILL.mdprescribes:resources/L10nBatchProcessor.csiterated the mappingDictionaryin enumeration order with a bareContains, and no sort.It is worse than a missing optimization, because of the
break:A label reading
"NO ITEMS FOUND"binds to a"NO"key and stops looking. It is also flaggedmatched, so it never appears in theunmatchedlist the method returns for exactly this purpose — a silent mis-binding rather than a visible failure. And sinceDictionaryenumeration order is unspecified, whether it happens at all varies between runs.Fixed by sorting longest-first, once, outside the per-label loop.
2.
physics-3d-collision's only reference file restated the spineAll 23 rows of
references/troubleshooting.md's symptom table are already covered bySKILL.md— its eleven Fast-Path sections and twelve checklist steps — in different words. Spot-checked before removing:SKILL.mdStep 1 — Rigidbody ruleOnCollisionEnternever fires on a player characterFast-Path 5andCharacterController ExceptionFast-Path 3andStep 2 — Interaction matrixStep 10 — TunnelingStep 11 — Overlapping colliders at simulation startFast-Path 7Step 7 — MeshCollider rulesThe table is removed. The seven Unity Manual links in the file's Resources section are kept — they appear nowhere else, and linking documentation rather than restating it is the direction we want.
SKILL.md's pointer is retitled from "Troubleshooting & Resources" to "Resources" to match.Scope
One behavioral fix, one redundancy removal. No skill trigger or description changes.